Adding option to overwrite while doing correct_motion and saving to a folder #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yger
added
enhancement
alejoe91
reviewed
Jun 27, 2024
alejoe91
reviewed
Jun 27, 2024
alejoe91
approved these changes
Jun 27, 2024
| @@ -204,6 +204,7 @@ def correct_motion( | |||
| recording, | |||
| preset="nonrigid_accurate", | |||
| folder=None, | |||
| overwrite=False, | |||
There was a problem hiding this comment.
This is not consistent with some otherplace in spikeinterface.
There was a problem hiding this comment.
I think we use it at many places! Save, analyzers, etc..
Only in run sorter this is different...
|
@yger why did you remove the code that does the overwriting? |
|
aie, mistake then, i'll check |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I've mixed up some git history I guess, so mayeb the best is to delete this PR and start a new one? I don't know how to properly revert, there are way too many changes in my commit that are not mine here |
alejoe91
previously approved these changes
Jul 1, 2024
|
the diff in files look really weird! @yger I would suggest making a clean PR without messing up with git history ;) |
|
Now this has been fixed and the diff is legit. Just squash everything |
alejoe91
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when doing motion correction, if saving to a folder we can not overwrite and an error is launched only at then end, after motion correction has been made. This PR adds the option to overwrite the motion folder